Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webgl): withParametersWebGL return value #2044

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix(webgl): withParametersWebGL return value #2044

merged 1 commit into from Mar 19, 2024

Conversation

Pessimistress
Copy link
Collaborator

This is breaking some test cases in deck.gl.

Change List

  • Device.withParametersWebGL should return value from func

ibgreen
ibgreen approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the use of this function will be reduced in coming deck releases

@Pessimistress Pessimistress merged commit 3829c90 into master Mar 19, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/with-parameters branch March 19, 2024 20:48
Pessimistress added a commit that referenced this pull request Mar 19, 2024
@Pessimistress
fix(webgl): withParametersWebGL return value (#2044)
ba9e3f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pessimistress @ibgreen