Do not reset scissorTest in WEBGLRenderPass #2045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing a regression in deck.gl's picking and collision filter. Calling
device.beginRenderPass()
orrenderPass.setParameters()
will always setscissorTest
tofalse
.It could be argued that
beginRenderPass
is expected to reset the state (questionable because it doesn't do this to any other parameter), howeversetParameters()
as a public method should never affect a value not present in the argument.Alternatively we can allow
scissorRect
to acceptnull
on which we disable scissor test.Change List
scissorTest
ifscissorRect
is present