fix(webgl): shader debug

[Pessimistress]

Change List

• Correct typo

Overall I am not sure what this code path is supposed to do. According to

luma.gl/modules/webgl/src/adapter/resources/webgl-shader.ts

Lines 71 to 74 in 0d1f1d9

	if (log.level === 0) {
	this.compilationStatus = 'pending';
	return;
	}

If log.level = 0, then compilationStatus will never be 'error'
If log.level = 1, then the shader instance would have called debugShader() already.

[ibgreen]

Overall I am not sure what this code path is supposed to do

Yes, I was experimenting with different approaches to controlling errors and what is in there is probably not the final word

• Checking shader compilation status is a driver roundtrip and significantly slows down the app.
• So the recommendation is to not check shader status unless program linking fails.
• Of course when debugging it is nice if the error is thrown from the shader code, arguably a bit easier to pinpoint the failure.
• I also implemented asynchronous shader compilation (unfortunately currently turned off by deck.gl as it was causing a small regression) and that also affects error checking flow.

[Pessimistress]

If it's intentional not to check shader status, should we remove the status check and just call debugShader after linking fails?

[ibgreen]

If it's intentional not to check shader status, should we remove the status check and just call debugShader after linking fails?

Yes sure, that could be an option. As already mentioned, the reason it is still there is that , when debugging it is nice if the error is thrown synchronously from the shader code, this makes faster to debug the failure as you can break on exceptions and see in the stack trace exactly when the shader/model etc is created.