Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(shadertools): Remove ShaderModuleInstance class #2074

Merged
merged 9 commits into from Apr 25, 2024
Merged

chore(shadertools): Remove ShaderModuleInstance class #2074

merged 9 commits into from Apr 25, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 18, 2024

For #

Background

  • Start removing ShaderModuleInstance as the typing confusion is causing problems.

Change List

  • Move the shadermodule instance fields to ShaderModule and populate them during instantiation.

@ibgreen ibgreen mentioned this pull request Apr 18, 2024
Merged
@ibgreen ibgreen marked this pull request as ready for review April 25, 2024 11:52
@ibgreen ibgreen merged commit 0af201f into master Apr 25, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/remove-shader-module-instance branch April 25, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ibgreen