Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI setup #2079

Merged
merged 1 commit into from Apr 30, 2024
Merged

chore: update CI setup #2079

merged 1 commit into from Apr 30, 2024

Conversation

Pessimistress
Copy link
Collaborator

This PR mirrors deck.gl's CI setup.

Change List

  • Publish to NPM from CI
  • Security best practices in test/website flows

tags:
- v*

jobs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much delicate config to duplicate across repos, at some point create our own github action? Is that even possible?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that will take time to develop and test.

@@ -0,0 +1,53 @@
import {execSync} from 'child_process';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these scripts go into ocular so they don't have to be copied into each repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep it in each repo for now as we don't have standardized changelog format.

@Pessimistress Pessimistress merged commit 9775cf3 into master Apr 30, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/ci branch April 30, 2024 16:38
Pessimistress added a commit that referenced this pull request May 10, 2024
@Pessimistress Pessimistress mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants