Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Break out Adapter class from Device #2085

Merged
merged 2 commits into from Apr 29, 2024
Merged

feat(core): Break out Adapter class from Device #2085

merged 2 commits into from Apr 29, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 28, 2024

For #

Background

  • Combining device registration as static Device methods was supposed to be a short cut but created more trouble than its worth.

Change List

  • Break out a proper Adapter class (a device factory)

@ibgreen ibgreen changed the title Ib/adapter feat(core): Break out Adapter class from Device Apr 28, 2024
@ibgreen ibgreen changed the base branch from master to ib/luma-object April 28, 2024 13:56
@ibgreen ibgreen force-pushed the ib/luma-object branch 2 times, most recently from 984a1a8 to d216f1b Compare April 28, 2024 22:18
@ibgreen ibgreen changed the base branch from ib/luma-object to master April 29, 2024 11:41
@ibgreen ibgreen merged commit ef95aa8 into master Apr 29, 2024
1 check passed
@ibgreen ibgreen deleted the ib/adapter branch April 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ibgreen