Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron support fixes #482

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Electron support fixes #482

merged 1 commit into from
Apr 3, 2018

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 2, 2018

For #477

Background

  • Add electron detection

Change List

  • Detect when running in electron, treat as browser
  • Automatically start tracking context when calling pushContextState

@ibgreen ibgreen added this to the 5.1.5 milestone Apr 2, 2018
@ibgreen ibgreen mentioned this pull request Apr 2, 2018
Closed
@ibgreen ibgreen merged commit 347cdeb into 5.1-release Apr 3, 2018
@ibgreen ibgreen deleted the ib/electron branch April 3, 2018 15:26
@jianhuang01 jianhuang01 removed this from the 5.1.5 milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @jianhuang01