Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete duplicate file #486

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Delete duplicate file #486

merged 1 commit into from
Apr 3, 2018

Conversation

hujiulong
Copy link
Contributor

Background

src/webgl/helpers/format-glsl-error.js and src/webgl-utils/format-glsl-error.js are duplicate files, and src/webgl/helpers/format-glsl-error.js is not used by other files.

Change List

  • remove src/webgl/helpers/format-glsl-error.js

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

ibgreen
ibgreen approved these changes Apr 3, 2018
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted!

As soon as you sign the CLA we will merge this PR.

@jianhuang01 jianhuang01 merged commit 2715caa into visgl:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hujiulong @CLAassistant @ibgreen @jianhuang01