Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add marker clustering example to website #108

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

wangela
Copy link
Collaborator

@wangela wangela commented Nov 29, 2023

Add the Marker Clustering example from #86 to the website

@usefulthink
Copy link
Collaborator

Unfortunately, we can't add examples that are using their own dependencies (like @googlemaps/markerclusterer in this case) to the website right now, since the dependencies from the examples/* subdirectories aren't automatically installed and are missing during the build.

But I take this as a note that we should solve this or at least make sure those examples are listed on the website (even if you'll need to open them in codesandbox to see them).

@wangela
Copy link
Collaborator Author

wangela commented Nov 29, 2023

Unfortunately, we can't add examples that are using their own dependencies (like @googlemaps/markerclusterer in this case) to the website right now, since the dependencies from the examples/* subdirectories aren't automatically installed and are missing during the build.

But I take this as a note that we should solve this or at least make sure those examples are listed on the website (even if you'll need to open them in codesandbox to see them).

oh woops, just saw this after I installed the dependency to the website folder! I'll leave it up to you whether this is acceptable or if we should close the PR without merging.

@wangela
Copy link
Collaborator Author

wangela commented Nov 30, 2023

After offline discussion, decided to link to CodeSandbox for examples with external dependencies. Updated /examples README with this guidance and applied to marker-clustering example.

@wangela
Copy link
Collaborator Author

wangela commented Nov 30, 2023

Also confirmed that adding an external link automatically adds the "external" styling to the link.
screenshot

@usefulthink
Copy link
Collaborator

That is so cool, thanks! I allowed myself to pull that regex masterpiece into it's own function.

@usefulthink usefulthink merged commit 37ce552 into visgl:main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants