Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use potentially unreliable addListener functions #158

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: don't use potentially unreliable addListener functions #158

merged 2 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. fix: don't use potentially unreliable addListener functions 

    As discovered in visgl#137, there are apparently situations where the `.addListener()` function that components inherit from the MVCObject class will return undefined in certain edge cases, like when the Map is rendering the fallback-screen for an invalid API-key.

Therefore we will use the hopefully more stable `google.maps.event.addListener` method everywhere.
    @usefulthink
    usefulthink committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    17de146 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/google-maps-api-loader.ts 

    Co-authored-by: Malte Modrow <malte.modrow@gmail.com>
    @usefulthink @mrMetalWood
    usefulthink and mrMetalWood committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    29eec1d View commit details
    Browse the repository at this point in the history