fix a bug where false would not be detected as parameter false #278
Conversation
src/components/info-window.tsx
Outdated
| @@ -98,7 +98,7 @@ export const InfoWindow = (props: PropsWithChildren<InfoWindowProps>) => { | |||
| openOptions.anchor = anchor; | |||
| } | |||
|
|
|||
| if (shouldFocus) { | |||
| if (shouldFocus === true || shouldFocus === false) { | |||
There was a problem hiding this comment.
I think the most accurate test here would be "has this been set in the props", so I think it should be if (shouldFocus !== undefined) { ... }. Am I missing something?
There was a problem hiding this comment.
in case its used in typescript that probably holds true,
what I committed is just in case you use it with vanilla javascript, then it makes sure its a boolean, aka is either true or false
I dont think it makes a difference, but if you object, we can change it to your suggestion
There was a problem hiding this comment.
I just think we shouldn't invent our own rules here, if the google maps API will accept 0 and 1 (it probably does), so should we.
There was a problem hiding this comment.
fair enough ill make the change
There was a problem hiding this comment.
changed now :)
realized that if shouldFocus is set to false, then it will not be set at all in the open call, so added distinguisher from null, sorry for the oversight!