feat(map): implement initial version of map-instance caching #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces map-instance caching, allowing maps to be persisted across unmount/remount cycles. BREAKING CHANGE: Introduction of map instance caching needed a change to the DOM-Structure produced by the map component (added a div-element owned by the Map component to contain the map instance).
usefulthink
added a commit
to usefulthink/react-google-maps
that referenced
this pull request
May 10, 2024
Introduction of the intermediate div with visgl#349 indirectly broke relative positioning of elements withing the map-container. Before that change, elements would be added to a container where position:relative was set by the Maps JavaScript API. This is no longer happening, so we need to set it ourselves.
usefulthink
added a commit
that referenced
this pull request
May 10, 2024
Introduction of the intermediate div with #349 indirectly broke relative positioning of elements withing the map-container. Before that change, elements would be added to a container where position:relative was set by the Maps JavaScript API. This is no longer happening, so we need to set it ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces map-instance caching, allowing maps to be persisted across unmount/remount cycles.
Fixes #319
BREAKING CHANGE: Introduction of map instance caching needed a change to the DOM-Structure produced by the map component (added a div-element owned by the Map component to contain the map instance).