Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #22

Closed
vicapow opened this issue Nov 13, 2015 · 11 comments
Closed

Improve documentation #22

vicapow opened this issue Nov 13, 2015 · 11 comments
Labels

Comments

@vicapow
Copy link
Contributor

vicapow commented Nov 13, 2015

No description provided.

@vicapow
Copy link
Contributor Author

vicapow commented Dec 13, 2015

Subtasks

@vicapow
Copy link
Contributor Author

vicapow commented Dec 13, 2015

See existing docs at: http://uber.github.io/react-map-gl/

@vicapow vicapow changed the title Add better documentation Improve documentation Dec 13, 2015
@vicapow
Copy link
Contributor Author

vicapow commented Dec 13, 2015

@wwwtyro feel like starting on this next? It's a bit more open ended than the other tasks. Otherwise, #17 would be great to nail down.

@wwwtyro
Copy link
Contributor

wwwtyro commented Dec 13, 2015

Sure, no problem!

On Sun, Dec 13, 2015 at 4:53 PM, Victor notifications@github.com wrote:

@wwwtyro https://github.com/wwwtyro feel like starting on this next?
It's a bit more open ended than the other tasks. Otherwise, #17
#17 would be great to nail
down.


Reply to this email directly or view it on GitHub
#22 (comment).

@vicapow
Copy link
Contributor Author

vicapow commented Dec 15, 2015

@wwwtyro one additional step I forgot to mention. Can you submit a separate diff to the gh-pages with just the result of running: npm run build? This should update the local bundle.js file.

@wwwtyro
Copy link
Contributor

wwwtyro commented Dec 15, 2015

#37 sorry about that!

@vicapow
Copy link
Contributor Author

vicapow commented Dec 15, 2015

it's all good!

@wwwtyro
Copy link
Contributor

wwwtyro commented Dec 22, 2015

Any interest in jsx-ifying the docs?

@vicapow
Copy link
Contributor Author

vicapow commented Dec 22, 2015

@wwwtyro not a bad idea. Maybe we could create a seperate task for that? But I think it still makes sense to keep the project on r-dom to avoid the added complexity of a build step and/or to avoid imposing the requirement on consumers of the component.

@wwwtyro
Copy link
Contributor

wwwtyro commented Dec 22, 2015

Ah, yeah, I see what you mean. 👍

@vicapow
Copy link
Contributor Author

vicapow commented Jan 6, 2016

I added some more detail to the docs. http://uber.github.io/react-map-gl/

@vicapow vicapow closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants