Add AttributionControl #1295
Merged
Add AttributionControl #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| customAttribution: PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string)]) | ||
| }); | ||
|
|
||
| const defaultProps = Object.assign({}, mapControlDefaultProps, { |
There was a problem hiding this comment.
how do you feel about destructuring here:
const defaultProps ={...mapControlDefaultProps, {
className: '',
toggleLabel: 'Toggle Attribution'
}};
| const toggleAttribution = useCallback(() => setShowCompact(value => !value), []); | ||
|
|
||
| return ( | ||
| <div style={{position: 'absolute', ...props.style}} className={props.className}> |
There was a problem hiding this comment.
take advantage of useMemo the same way you did in other PRs
useMemo(() => ({position: 'absolute', ...(props.style || {})}), [props.style])
I would make sure prop.style is not null
There was a problem hiding this comment.
I believe the spread operator supports null/undefined (similar to Object.assign)
There was a problem hiding this comment.
Will address in #1297
| <div | ||
| ref={containerRef} | ||
| aria-pressed={showCompact} | ||
| className={`mapboxgl-ctrl mapboxgl-ctrl-attrib ${compact ? 'mapboxgl-compact' : ''} ${ |
There was a problem hiding this comment.
if we are planning on having several instances of class name manipulation we should think about using something like classnames to better handle these cases
macrigiuseppe
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1129