Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style diff warning when reusing map #816

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Fix style diff warning when reusing map #816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9de39a
fix diff warning when reusing map
Jun 4, 2019
f424790
clean up
Jun 4, 2019
c24497f
add comments
Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mapbox/mapbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,9 @@ export default class Mapbox {
// Step3: update style and call onload again
if (props.mapStyle) {
this._map.setStyle(props.mapStyle, {
diff: true
// From the user's perspective, there's no "diffing" on initialization
// We always rebuild the style from scratch when creating a new Mapbox instance
diff: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add your comment here.

});
}

Expand Down