Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_box_scores returning same player name multiple times or incorrect player name #73

Open
brianpmackey opened this issue Feb 10, 2022 · 0 comments

Comments

@brianpmackey
Copy link

brianpmackey commented Feb 10, 2022

box_scores.get_box_scores is returning the same player name multiple times on the same team or opponent and in some cases the player names are incorrect. The stats seem ok, just the player names. This seems to occur in many of the box scores I have looked at. Here are a few examples:

2018-11-30, ORL, PHO, GAME, BASIC - Aaron Gordon returned as himself as part of ORL and instead of De'Anthony Melton for PHO

2021-04-22, LAL, DAL, GAME, BASIC - Alex Caruso returned as himself as part of LAL and instead of Luka Dončić and J.J. Reddick for DAL. Looking deeper at this game, several of the DAL player names are incorrect.

aaroncolesmith added a commit to aaroncolesmith/basketball_reference_scraper that referenced this issue May 13, 2022
Previously, this would only call out to team1 -- so if you are removing accents for a player on team 2 (ie Luka) it would pull back a player from team 1. This is raised in issue 73 -- vishaalagartha#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant