Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update : data's are updated #119

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Update : data's are updated #119

merged 3 commits into from
Oct 5, 2021

Conversation

mohammedafeef
Copy link

  • react warnings are resolved
  • 4 colors are added
  • 4 colors are added

Update : data's are updated
23ca310 
* react warnings are resolved
* 4 colors are added
* 4 colors are added
@netlify
Copy link

netlify bot commented Oct 3, 2021 •
edited
Loading

✔️ Deploy Preview for wizardly-hoover-38f71b ready!

🔨 Explore the source changes: a0a220c

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-hoover-38f71b/deploys/615c6d4ce379a50008c04f3d

😎 Browse the preview: https://deploy-preview-119--wizardly-hoover-38f71b.netlify.app/

This was referenced Oct 3, 2021
Closed
Closed
Closed
vishal-codes
vishal-codes requested changes Oct 4, 2021
View reviewed changes
Copy link
Owner

@vishal-codes vishal-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammedafeef u haven't added the colors and language in alphabetical order please arrange them and also replace " with ' also what kind of change u maide in src/components/base/Convert.js

@mohammedafeef
Copy link
Author

mohammedafeef commented Oct 4, 2021 •
edited
Loading

@vishal-codes In src/components/base/Convert.js changed != to !== for removing the react warning

fix: color and language updated
c512140 
* color and language updated in alphabetical order
* " changed to \'

Updated By: Afeef
@mohammedafeef
Copy link
Author

@vishal-codes color ( SandyBrown, PaleVioletRed, NavajoWhite, Khaki ) and language ( Latvian, Khmer, Igbo, Hausa ) arranged in alphabetical order and also replaced " with '

@vishal-codes
Copy link
Owner

Great work @mohammedafeef Do consider connecting with me on twitter @vishaltwts :)
@sakshamgurbhele can u please label this pr and merge it

@sakshamgurbhele sakshamgurbhele merged commit 980a22a into vishal-codes:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakshamgurbhele sakshamgurbhele sakshamgurbhele approved these changes

@vishal-codes vishal-codes vishal-codes approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohammedafeef @vishal-codes @sakshamgurbhele