Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make does not properly uninstall: typo in variable name #97

Closed
vgratian opened this issue Dec 27, 2021 · 1 comment
Closed

Make does not properly uninstall: typo in variable name #97

vgratian opened this issue Dec 27, 2021 · 1 comment

Comments

@vgratian
Copy link

vgratian commented Dec 27, 2021 •
edited
Loading

In src/tools/make/oberon.mk#L193:

@sh src/tools/make/addlibrary.sh uninstall "$(INSTALLDIR)/lib" $(oname)

$(oname) should be $(ONAME) (make is case-sensitive).

Because of this typo, when you run make uninstall, make does not remove /etc/ld.so.conf.d/libvoc.conf, instead, it tries to remove /etc/ld.so.conf.d/lib.conf.
norayr added a commit that referenced this issue Dec 27, 2021
@norayr
typo fix: oname should be ONAME
3d62284 
#97
@norayr
Copy link
Member

norayr commented Dec 27, 2021

fixed, thank you for noticing!

@norayr norayr closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@norayr @vgratian