Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dtt from tests #103

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Removed dtt from tests #103

merged 1 commit into from
Aug 22, 2020

Conversation

douglas-gibbons
Copy link
Collaborator

Simplified testing requirements

@douglas-gibbons douglas-gibbons merged commit 125caf6 into master Aug 22, 2020
@deiga
Copy link

deiga commented Aug 22, 2020

You swapped one dependency for another, what was simplified?

@douglas-gibbons douglas-gibbons deleted the testfix branch August 22, 2020 22:55
@douglas-gibbons
Copy link
Collaborator Author

Turns out dtt != ddt. requirements.txt imported the wrong library, and in my effort to fix it, I ended up moving away from ddt (or was it dtt) altogether.

Seemed important to get the tests working so I could go through the backlog of pull requests. Anything there that you really need?

@deiga
Copy link

deiga commented Aug 23, 2020

Turns out dtt != ddt. requirements.txt imported the wrong library, and in my effort to fix it, I ended up moving away from ddt (or was it dtt) altogether.

Seemed important to get the tests working so I could go through the backlog of pull requests. Anything there that you really need?

Nah, I was just asking for clarification, because the description didn't seem to fit what was done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants