Get broadcast addr in AddrList #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pengfei Ni <feiskyer@gmail.com>
|
@vishvananda Could you have a look at this? |
feiskyer
added a commit
to feiskyer/ovn-kubernetes
that referenced
this pull request
May 2, 2017
addrList is a workround for also getting broadcast addr. It should be replaced by netlink.AddrList after vishvananda/netlink#226 is merged. Signed-off-by: Pengfei Ni <feiskyer@gmail.com>
|
@vishvananda Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip addr showcommand shows broadcast address, but it is not set inAddrList().This PR sets broadcast addr so it is consistent with
ip addr show.