Add bridge dump support #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diconico07
force-pushed
the
add_bridge_dump
branch
from
67a7a9c
to
51fdede
Compare
|
Added support of MasterIndex in neighHandle() as I forgot it at first. |
diconico07
force-pushed
the
add_bridge_dump
branch
from
51fdede
to
4270a96
Compare
|
The code here looks correct. Is it possible to create a test to validate that it is working properly? |
diconico07
force-pushed
the
add_bridge_dump
branch
5 times, most recently
from
75094cd
to
d20ad42
Compare
|
I had to change a bit more than I thought for the tests. The only disappointing thing is the need for a vxlan interface in the test as the FDB entries for vxlan interfaces are really close to usual neigh entries and can thus be checked using the same function in the tests. |
|
Anything else needed from me ? |
|
Please squash your commits into one |
When subscribing to neigh updates, the updates for all neigh protocol families are received. However when listExisting is set, the request is made with AF_UNSPEC family, this request does not include AF_BRIDGE entries. This patch add a second request for AF_BRIDGE entries. Add test for existing AF_BRIDGE entry and make expectNeighUpdate take a slice of expected updates Creates a VXLAN interface for this test as its AF_BRIDGE entries looks a lot like usual ones Also add support for latest (2014+) neighbour attributes NDA_MASTER was added back in 2014, it indicates whether a neigh entry is linked to a master interface and index of this interface. The other entries, namely NDA_LINK_NETNSID and NDA_SRC_VNI were added later and will need extra handling. Signed-off-by: Nicolas Belouin <nicolas.belouin@gandi.net>
diconico07
force-pushed
the
add_bridge_dump
branch
from
d20ad42
to
9f5645c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for bridge neigh entries dump on subscribe and also add a bridge related attribute to neigh structure