Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze_bn #5

Closed
JNNNNYao opened this issue Jul 24, 2021 · 1 comment
Closed

freeze_bn #5

JNNNNYao opened this issue Jul 24, 2021 · 1 comment

Comments

@JNNNNYao
Copy link

Hi, thanks for providing this great work!!

It seems that in the implementation of DeepLab with ResNet101, no matter freeze_bn is true or false it will call self._freeze_bn so the BN will be fixed. Should line 196 be commented out?

da-sac/models/deeplabv2.py

Lines 190 to 196 in b6f0a90

# fixing BN of the backbone
if freeze_bn:
print("DeepLabv2/ResNet-101: Fixing BN")
self._freeze_bn(self)
else:
print("DeepLabv2/ResNet-101: Training BN")
self._freeze_bn(self)

Thanks:)

arnike added a commit that referenced this issue Aug 2, 2021
@arnike
Copy link
Collaborator

arnike commented Aug 2, 2021

Hi Matthew,

thanks a lot for pointing this out, you're right this is incorrect. I seem to have introduced this bug when merging branches for code release (I had slightly different versions of the code for ABN training and training with augmentation consistency), so the reported numbers are luckily not affected. Thanks again!

Best,
Nikita

@arnike arnike closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants