Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing --serial command. TODO added #175

Closed
wants to merge 1 commit into from

Conversation

AnthonyAkentiev
Copy link

When running tests with --serial parameter -> causes error because assert object is NULL.

Also i've found 2nd bug with --serial execution.
In case test is not calling 'beforeExit' -> test would always fail with "test timed out" error. I haven't fixed that yet, but wrote comment.

@tj
Copy link
Member

tj commented Nov 24, 2013

might want to check out mocha this lib is just sticking around for historical reasons but it was a quick hack

@AnthonyAkentiev
Copy link
Author

Hehe. Yeah, i saw that comment. Ok, i will check Mocha. I kind of like expresso, it is so easy to use... Can you merge my pull-request?

@bithavoc
Copy link

bithavoc commented May 5, 2014

+1

@tj
Copy link
Member

tj commented May 5, 2014

mocha is equally easy to use, this lib is deprecated

@tj tj closed this May 5, 2014
@bithavoc
Copy link

bithavoc commented May 5, 2014

@visionmedia if the library is deprecated, we should add this to Readme.md.

In fact, I'm actually using mocha and just googled assert.isDefined and expresso came up first, would you consider adding these additional assertions to mocha?

The code is right here: https://github.com/visionmedia/expresso/blob/master/bin/expresso#L312

I can send a pull request to mocha.

@tj
Copy link
Member

tj commented May 5, 2014

it says to use mocha in the readme. Nah there's a lot of different libs that can be used with mocha for assertions, assert(null != foo) from core's assert lib works for that though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants