Fix: code that uses setTimeout causes expresso to hang indefinitely #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce the process to quit after all have completed + timeout
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It seems any code that uses setInterval causes expresso to hang and not exit. I assume that this is because setInterval keeps the process alive indefinitely.
My fix: keep a count of the number of test files processed and the number of tests remaining to finish + force the process to exit when everything has been completed. I add another timeout before the force quit just in case any async code is still running.
I've also got a couple of small fixes for failing tests in there.
Thanks,
Steve