Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests succeed on rejected falsey promises #1191

Closed
djechlin opened this issue Apr 14, 2014 · 0 comments
Closed

Tests succeed on rejected falsey promises #1191

djechlin opened this issue Apr 14, 2014 · 0 comments

Comments

@djechlin
Copy link

Using Q, one of these two tests fails and the other one succeeds:

describe("mocha with promises", function() {
it("should fail on falsey rejected promises", function() {
    return q.reject(false);
});

it("should fail on truthy rejected promises", function() {
    return q.reject(true);
});
});

It appears that q.reject(x) where x is one of the six falsey values does not fail the test, whereas truthy values do.

jonathanong added a commit that referenced this issue Jul 8, 2014
Fix #1191 - Tests succeed on rejected falsey promises
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant