Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onpopstate doesn't include query string when e.state = null #495

Closed
cj-idoctours opened this issue Aug 28, 2018 · 1 comment
Closed

onpopstate doesn't include query string when e.state = null #495

cj-idoctours opened this issue Aug 28, 2018 · 1 comment
Labels

Comments

@cj-idoctours
Copy link

When e.state = null (like when clicking on a link that is the same as the current location except with a hash), the query parameters were not added to page.show()

This problem occurs on line 998 on page.js

Problem code:
998 page.show(loc.pathname + loc.hash, undefined, undefined, false);

Fix:
998 page.show(location.pathname + location.search + location.hash, undefined, undefined, false);

@matthewp matthewp added the bug label Sep 4, 2018
@matthewp
Copy link
Collaborator

matthewp commented Sep 7, 2018

This is a bit of a tough one to test.

matthewp pushed a commit that referenced this issue Sep 7, 2018
When navigating to the current page, include the querystring as part of
the Context.

Fixes #495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants