Fix first sample in Readme.md #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 26 was `res.send(200, {...})` but would give this warning when running:
`express deprecated res.send(status, body): Use res.status(status).send(body) instead`
Line 32 was `.expect('Content-Length', '15')` but it gave me an error:
`Error: expected "Content-Length" matching 20, got "15"`
I've fixed those.
(using Express 4.10.3)
|
The devDependency is 3.1.0, so not sure if it makes sense to update the example but not the dependency. |
|
@seriema if you can update the dev deps as well, that would be great |
|
Good point @ilanbiala. I thought I was just using a simple test-case. @jonathanong Changing the devDependency could have a whole lot of consequences I don't feel qualified to test for. =/ My PR's was just to update the Readme so people don't waste as much time as I did when I tried to follow them. I could update this PR with a note on Express versions but I'm not sure what the project would prefer. |
|
dep and sample have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 26 was
res.send(200, {...})but would give this warning when running:express deprecated res.send(status, body): Use res.status(status).send(body) insteadLine 32 was
.expect('Content-Length', '15')but it gave me an error:Error: expected "Content-Length" matching 20, got "15"I've fixed those.
(using Express 4.10.3)