Close up listening servers after the tests #71

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

mdp commented Aug 9, 2013

If we open up a ephemeral port to test on, at the end of the test we
should close it up.

Apparently I deleted the other branch by mistake on #51, and nothing got merged in.

@mdp mdp Close up listening servers after the tests
If we open up a ephemeral port to test on, at the end of the test we
should close it up.
e1ebe92

@gjohnson gjohnson commented on the diff Sep 16, 2013

lib/test.js
});
return this;
};
+Test.prototype.close = function(fn){
+ if (this._closeCleanup) {
+ this.app.close(fn);
+ return true;
+ } else { return false }
+};
@gjohnson

gjohnson Sep 16, 2013

Member

Why not just: if (this._closeCleanup) this.app.close(fn); ?

Member

gjohnson commented Dec 16, 2013

Closing since I haven't heard back.

gjohnson closed this Dec 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment