Skip to content

Commit

Permalink
Fix IE8 error when a dialog with effect closes
Browse files Browse the repository at this point in the history
use closure instead of IE's broken setTimeout argument passing
  • Loading branch information
jpjoyal committed Jun 4, 2012
1 parent 475e147 commit 3e01c18
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/components/dialog/dialog.js
Expand Up @@ -225,9 +225,9 @@ Dialog.prototype.hide = function(ms){
// hide / remove
this.el.addClass('hide');
if (this._effect) {
setTimeout(function(self){
setTimeout(function(){
self.remove();
}, 500, this);
}, 500);
} else {
self.remove();
}
Expand Down

0 comments on commit 3e01c18

Please sign in to comment.