Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost zone generation taking a lot of resources. #5598

Open
brugger1 opened this issue Apr 2, 2021 · 1 comment
Open

Ghost zone generation taking a lot of resources. #5598

brugger1 opened this issue Apr 2, 2021 · 1 comment
Assignees
Labels
asc related to an asc funded project bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Milestone

Comments

@brugger1
Copy link
Collaborator

brugger1 commented Apr 2, 2021

I had a user running VisIt and it kept running out of memory generating ghost zone information. He was doing a filled boundary plot, which required ghost zones.

Here are some annotated excerpts from the level 5 debug log.

avtLocalStructuredDomainBoundaryList::GlobalGather
avtLocalStructuredDomainBoundaryList::GlobalGenerate: all lists size=4600
avtLocalStructuredDomainBoundaryList::GlobalGenerate: Domain 0 is enabled
avtLocalStructuredDomainBoundaryList::GlobalGenerate: Number of known domains 4600
avtGenericDatabase::GetDomainBoundaryInformation: Global for local success
GetDomainBoundaryInformation: Returning
avtGenericDatabase::CommunicateGhosts:
ghostType == GHOST_ZONE_DATA && HasDomainBoundaryInfo
avtGenericDatabase::CommunicateGhostZonesFromDomainBoundariesFromFile:
avtGenericDatabase::CommunicateGhostZonesFromDomainBoundaries:

dbi->ExchangeMaterial:
FillMixedBoundaryData:
SIGBUS

@brugger1 brugger1 added bug Something isn't working asc related to an asc funded project likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels Apr 2, 2021
@brugger1 brugger1 self-assigned this Apr 6, 2021
@brugger1 brugger1 added priority a priority ticket reviewed Issue has been reviewed and labeled by a developer labels Apr 6, 2021
@brugger1 brugger1 added this to the 3.2.1 milestone Apr 6, 2021
@markcmiller86
Copy link
Member

markcmiller86 commented Apr 6, 2021

So, that stuff about maximum material number I recall is here,

// Jeremy Meredith, Thu Nov 4 13:36:07 PST 2004
// 'maxMat' had a +1 from the actual highest used material number, but
// checks for invalid numbers were using '> maxMat' instead of '>= maxMat'.
// I change maxMat to be the actual highest used material number and
// allocated an array of size maxMat+1 for the lut, because having maxMat
// mean "highest used material number" seems clearer than changing the
// invalid checks to be ">=".
//

So, maybe just taking a quick look here to ensure the database itself isn't using some wonky material numbers like 47,232,211 and that we won't allocate an array that large here...

@brugger1 brugger1 removed their assignment May 25, 2021
@brugger1 brugger1 modified the milestones: 3.2.1, 3.2.2 May 25, 2021
@brugger1 brugger1 modified the milestones: 3.2.2, 3.2.3 Aug 17, 2021
@brugger1 brugger1 modified the milestones: 3.2.3, 3.2.4 Feb 11, 2022
@brugger1 brugger1 modified the milestones: 3.2.4, 3.3.1 Jun 14, 2022
@brugger1 brugger1 modified the milestones: 3.3.1, 3.3.2 Aug 19, 2022
@brugger1 brugger1 removed the priority a priority ticket label Nov 15, 2022
@brugger1 brugger1 modified the milestones: 3.3.2, 3.4 Nov 15, 2022
@brugger1 brugger1 modified the milestones: 3.4, 3.4.2 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asc related to an asc funded project bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Projects
None yet
Development

No branches or pull requests

2 participants