Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X Ray Image Query/Blueprint Plugin VisIt 3.3.3 Enhancements #18576

Conversation

JustinPrivitera
Copy link
Member

@JustinPrivitera JustinPrivitera commented Mar 16, 2023

Description

Addresses bullets in #17791

If we had more time this would likely be better as multiple PRs.

X Ray Query:

  • Added spectra topo and fields
  • Added tests for them
  • Reworked some of the conduit code so that it is better Conduit style
  • All query errors now say "ERROR:" at the beginning
  • Cleaned up some error handling
  • Updated many tests and added new ones that test multiple energy group bins with different values; removed old tests that are now superfluous

Blueprint Plugin:

  • Added support for true 1D topos/fields to be rendered as curves
  • Added tests for 1D curves

Type of change

  • [ ] Bug fix
  • New feature~~
  • [ ] Documentation update
  • Other~~
    code improvment

How Has This Been Tested?

Built and ran on rztopaz
All x ray query tests pass
There is one blueprint test that does not pass >:( - see comment below

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • I have commented my code where applicable.~~
  • I have updated the release notes.~~
  • [ ] I have made corresponding changes to the documentation.
  • I have added debugging support to my changes.~~
  • I have added tests that prove my fix is effective or that my feature works.~~
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • I have added new baselines for any new tests to the repo.~~
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

@JustinPrivitera JustinPrivitera changed the title X Ray Image Query: Add spectra topo and fields + misc code improvements X Ray Image Query/Blueprint Plugin VisIt 3.3.3 Enhancements Mar 22, 2023
@JustinPrivitera JustinPrivitera marked this pull request as ready for review March 23, 2023 01:17
@JustinPrivitera
Copy link
Member Author

JustinPrivitera commented Mar 23, 2023

The failing blueprint test also fails on develop; the diff is 4 pixels. I assume this is because of some slight difference between pascal and Cyrus's mac. Should I update the baseline here then?

@brugger1
Copy link
Collaborator

Yes, you should rebaseline based on pascal.

@markcmiller86
Copy link
Member

@JustinPrivitera JustinPrivitera merged commit 3229449 into 3.3RC Mar 23, 2023
@JustinPrivitera JustinPrivitera deleted the task/JustinPrivitera/03_15_23/xray_query_spectra_topo_and_code_improvements branch March 23, 2023 20:32
@biagas
Copy link
Contributor

biagas commented Mar 24, 2023

I figured out why you needed to include 'visit_vtk/lightweight'. avtBlueprint uses vtkVisItUtility, which is from visit_vtk/lightweight. You should change the include and link with lightweight_visit_vtk instead of visit_vtk.

@JustinPrivitera
Copy link
Member Author

merge w/ develop in #18599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants