-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X Ray Image Query/Blueprint Plugin VisIt 3.3.3 Enhancements #18576
X Ray Image Query/Blueprint Plugin VisIt 3.3.3 Enhancements #18576
Conversation
…ectra_topo_and_code_improvements
The failing blueprint test also fails on develop; the diff is 4 pixels. I assume this is because of some slight difference between pascal and Cyrus's mac. Should I update the baseline here then? |
Yes, you should rebaseline based on pascal. |
Have a look at |
I figured out why you needed to include 'visit_vtk/lightweight'. avtBlueprint uses vtkVisItUtility, which is from visit_vtk/lightweight. You should change the include and link with lightweight_visit_vtk instead of visit_vtk. |
merge w/ develop in #18599 |
Description
Addresses bullets in #17791
If we had more time this would likely be better as multiple PRs.
X Ray Query:
Blueprint Plugin:
Type of change
[ ] Bug fix[ ] Documentation updatecode improvment
How Has This Been Tested?
Built and ran on rztopaz
All x ray query tests pass
There is one blueprint test that does not pass >:( - see comment below
Reminders:
Checklist:
[ ] I have made corresponding changes to the documentation.