fix builds for macos 12.6 #18642

markcmiller86 · 2023-04-12T03:50:01Z

Description

Resolves #

Type of change

Bug fix~~
New feature~~
Documentation update~~
Other~~

How Has This Been Tested?

Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

I have commented my code where applicable.~~
I have updated the release notes.~~
I have made corresponding changes to the documentation.~~
I have added debugging support to my changes.~~
I have added tests that prove my fix is effective or that my feature works.~~
I have confirmed new and existing unit tests pass locally with my changes.~~
I have added new baselines for any new tests to the repo.~~
I have NOT made any changes to protocol or public interfaces in an RC branch.~~

src/tools/dev/scripts/bv_support/bv_hdf5.sh

markcmiller86 · 2023-04-12T16:07:54Z

src/CMakeLists.txt

@@ -2346,7 +2346,7 @@ IF (NOT WIN32)
        SET (CPACK_BUNDLE_PLIST "${VISIT_BINARY_DIR}/tools/dev/scripts/Info.plist")
        SET (CPACK_BUNDLE_STARTUP_COMMAND "${VISIT_BINARY_DIR}/exe/visit_macos_launcher")
    ELSE(APPLE AND VISIT_CREATE_APPBUNDLE_PACKAGE)
-        SET(CPACK_GENERATOR "TGZ")
+        SET(CPACK_GENERATOR "TXZ")


This change leads to 100Mb smaller tarball on mac. Would assume similar savings on other platforms. If we could control flags to xz, we could improve that a bit more. We could do that if we used Python tools to tar and compress...as we do in the top level data dir.

markcmiller86 · 2023-04-12T16:28:12Z

src/tools/dev/masonry/masonry.py

-            cmd = "hdiutil create -srcFolder %s -o %s" % (src_folder, temp_dmg)
+            # ULMO format (xz) is 1/2 the size of default format (UDZO which is zlib level 1)
+            #cmd = "hdiutil create -srcFolder %s -o %s" % (src_folder, temp_dmg)
+            cmd = "hdiutil create -format ULMO -srcFolder %s -o %s" % (src_folder, temp_dmg)


This change leads to 275Mb smaller .dmg file on mac

src/tools/dev/scripts/bv_support/bv_hdf5.sh

…visit into rel-mcm86-11apr23-build-fixes

markcmiller86 · 2023-04-14T17:25:21Z

src/tools/dev/scripts/bv_support/bv_mpich.sh

-    export MPICH_URL=${MPICH_URL:-http://www.mpich.org/static/tarballs/${MPICH_VERSION}}
-    export MPICH_MD5_CHECKSUM="9ed4cabd3fb86525427454381b25f6af"
-    export MPICH_SHA256_CHECKSUM="fe551ef29c8eea8978f679484441ed8bb1d943f6ad25b63c235d4b9243d551e5"
+    if [[ "$OPSYS" == "Darwin" ]]; then


Updating mpich with newer libtool involves quite a bit. No easy way to just patch it. So, I created a new third-party asset named mpich-3.3.1-libtool-2.4.6 which expands also to mpich-3.3.1 (honestly should be harmless if its used on non-macOS systems too).

This commit is needed for macOS 12.6. So I cherry picked it to #19293

src/tools/dev/scripts/bv_support/bv_mpich.sh

markcmiller86 · 2023-04-14T18:28:14Z

src/tools/dev/scripts/bv_support/bv_advio.sh

+        sed -i orig -e 's/^main()/int main()/' configure
+    else
+        sed -i.orig -e 's/^main()/int main()/' configure
+    fi
    info "Invoking command to configure AdvIO"


Many try-run blocks for sizes of types in configure defined a main() with no type which causes modern compilers to fail outright. This sed command fixes them. Its a little different on macOS then other *nix systems. Windows?

@markcmiller86 Sorry, didn't see the question about Windows sooner. Not using the build_visit script on Windows, so not an issue.

markcmiller86 · 2023-04-14T18:29:25Z

@biagas and @brugger1 I've pulled this out of DRAFT mode. I think it is about ready.

markcmiller86 · 2023-08-25T23:41:21Z

Ok, so my attempt to build from a fresh state for this branch did fail in Qt. And I need to investigate and fix.

markcmiller86 · 2023-08-26T00:10:43Z

The problem with Qt5 on macOS is that it does not support python3. It requires a python2 (for at least QtWebEngine anyways...maybe we should explicitly disable that?). On my macOS 12.6.7, with a vanilla PATH, I have a python3 but no python or python2 and that is what Qt is looking for. Now, I have a version 2 python there in /opt/local/bin. But, there is a ton of other stuff in /opt/local/bin. So, I don't want /opt/local/bin in my path. So, I added a symlink named python in a random dir and added that dir to my path so hopefully it will find that version 2 python

markcmiller86 · 2023-08-26T05:09:04Z

I wound up having to add -skip webengine to Qt configure.

brugger1 · 2023-08-28T15:00:37Z

There is a patch in bv_qt.sh that should handle the python issue, but it is only applied for Qt 5.10.1. It looks like it should also be added for Qt 5.14.2.

visit/src/tools/dev/scripts/bv_support/bv_qt.sh

Lines 287 to 296 in 02e4b02

    
           # 
        
           # If python doesn't exist, substitute python2 for python. 
        
           # 
        
           python -c "print(1)" 
        
           if [[ $? != 0 ]] ; then 
        
               info "Patching qt 5.10.1 for python to python2" 
        
               cd qtdeclarative 
        
               find . -type f -exec sed -i "s/python/python2/g" {} \; 
        
               cd .. 
        
           fi

cyrush · 2024-01-11T17:10:38Z

PR #18848 will include the changes for macOS.

cyrush · 2024-02-13T23:31:40Z

closing in lieu of PR #18848 and #19293

fix builds for macos 12.6

4530296

markcmiller86 requested review from brugger1 and biagas April 12, 2023 03:50

markcmiller86 added 2 commits April 11, 2023 21:36

use lzma compression for packaging

e413ee4

remove unneeded arg to tar -x

7f27f53

biagas reviewed Apr 12, 2023

View reviewed changes

src/tools/dev/scripts/bv_support/bv_hdf5.sh Outdated Show resolved Hide resolved

markcmiller86 commented Apr 12, 2023

View reviewed changes

brugger1 requested changes Apr 12, 2023

View reviewed changes

src/tools/dev/scripts/bv_support/bv_hdf5.sh Outdated Show resolved Hide resolved

markcmiller86 added 4 commits April 12, 2023 21:09

Update src/tools/dev/scripts/bv_support/bv_hdf5.sh

e94a846

Update src/tools/dev/scripts/bv_support/bv_hdf5.sh

cd4c277

use updated libtoolized mpich on macOS

bfc8a35

Merge branch 'rel-mcm86-11apr23-build-fixes' of github.com:visit-dav/…

a0c453f

…visit into rel-mcm86-11apr23-build-fixes

markcmiller86 commented Apr 14, 2023

View reviewed changes

markcmiller86 added 3 commits April 14, 2023 10:45

patches for macOS 12.6

42134f4

fix builds for macOS 12

b0f3090

fix configure for all OSs

fad368a

markcmiller86 commented Apr 14, 2023

View reviewed changes

markcmiller86 marked this pull request as ready for review April 14, 2023 18:28

brugger1 previously approved these changes Apr 14, 2023

View reviewed changes

more build fixes

50b3863

markcmiller86 dismissed brugger1’s stale review via 50b3863 May 30, 2023 21:33

markcmiller86 mentioned this pull request Jun 8, 2023

build visit fails to build qt5 on rztopaz toss4 #18747

Open

JustinPrivitera mentioned this pull request Aug 18, 2023

qt 5.14.2 build fail on macOS 12 #18890

Open

fix typo

d22e4aa

snapshot

b0a7fd4

JustinPrivitera mentioned this pull request Sep 14, 2023

develop branch build issues with VTK-8.1.0 and QT-5.14.2 on Ubuntu22 #18931

Open

cyrush added this to the 3.4.1 milestone Jan 11, 2024

cyrush mentioned this pull request Jan 17, 2024

Initial build_visit changes for darwin arm64 #18475

Closed

9 tasks

cyrush closed this Feb 13, 2024

heinsimon mentioned this pull request Mar 22, 2024

3.3.3 build on ubuntu 22.04: build qt fails #19411

Open

markcmiller86 deleted the rel-mcm86-11apr23-build-fixes branch May 4, 2024 00:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix builds for macos 12.6 #18642

fix builds for macos 12.6 #18642

markcmiller86 commented Apr 12, 2023

markcmiller86 Apr 12, 2023

markcmiller86 Apr 12, 2023

markcmiller86 Apr 14, 2023

markcmiller86 Feb 19, 2024

markcmiller86 Apr 14, 2023 •

edited

biagas Aug 21, 2023

markcmiller86 commented Apr 14, 2023

markcmiller86 commented Aug 25, 2023

markcmiller86 commented Aug 26, 2023

markcmiller86 commented Aug 26, 2023

brugger1 commented Aug 28, 2023

cyrush commented Jan 11, 2024

cyrush commented Feb 13, 2024

fix builds for macos 12.6 #18642

fix builds for macos 12.6 #18642

Conversation

markcmiller86 commented Apr 12, 2023

Description

Type of change

How Has This Been Tested?

Reminders:

Checklist:

markcmiller86 Apr 12, 2023

Choose a reason for hiding this comment

markcmiller86 Apr 12, 2023

Choose a reason for hiding this comment

markcmiller86 Apr 14, 2023

Choose a reason for hiding this comment

markcmiller86 Feb 19, 2024

Choose a reason for hiding this comment

markcmiller86 Apr 14, 2023 • edited

Choose a reason for hiding this comment

biagas Aug 21, 2023

Choose a reason for hiding this comment

markcmiller86 commented Apr 14, 2023

markcmiller86 commented Aug 25, 2023

markcmiller86 commented Aug 26, 2023

markcmiller86 commented Aug 26, 2023

brugger1 commented Aug 28, 2023

cyrush commented Jan 11, 2024

cyrush commented Feb 13, 2024

markcmiller86 Apr 14, 2023 •

edited