Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing mapnode vectors #19479

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

biagas
Copy link
Contributor

@biagas biagas commented May 1, 2024

Description

Resolves #19324
See discussion there for more comments.

Type of change

  • Bug fix~~
  • [ ] New feature
  • [ ] Documentation update
  • [ ] Other

How Has This Been Tested?

User specified legend labels are now written to session/config files correctly, no '()' or ',', and parsed correctly when read back in.

Checklist:

  • I have commented my code where applicable.~~
  • I have updated the release notes.~~
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

@biagas biagas merged commit 77e2259 into 3.4RC May 1, 2024
4 checks passed
biagas added a commit that referenced this pull request May 1, 2024
* Modified ConvertToString to remove '()' and ','.
Resolves #19324.

* Modified ConvertToString to remove '()' and ','.
Resolves #19324.

* Update release notes.
biagas added a commit that referenced this pull request May 1, 2024
* Modified ConvertToString to remove '()' and ','.
Resolves #19324.

* Modified ConvertToString to remove '()' and ','.
Resolves #19324.

* Update release notes.
@biagas biagas deleted the bugfix/biagas/fix_writing_mapnode_vectors branch May 2, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants