fix(hierarchical): ignore invisible nodes #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout originally made space for invisible nodes (for example after clustering). Now it takes into account only the nodes that are actually rendered solving the problems with mysterios empty spaces in hierarchies with clusters.
The example is mostly rewritten. It has brand new design. A lot of weird stuff was rewritten (like a comment talking about randomly generating nodes when in fact it was just generating ordered numbers 0 to 18 in simple for; edges being pushed one by one into an array; the String constructor etc.) The example now allows layouting method and shaking direction to be chosen using radio buttons (ordinary buttons were used before) and checkboxes to choose which nodes should be clustered.
|
Very keen for this to be merged in, will solve a number of problems I have been experiencing. 👍 |
|
Hi @EquiAvia, are there any other issues this resolves? |
Not from a VisJs perspective, but it resolves a number of user experience challenges I have had with the large extra spaces allocated to the hidden nodes in our app. Thank you for keeping VisJs alive. |
|
I'm glad to hear that my work here helps. |
yotamberk
approved these changes
Nov 28, 2019
|
🎉 This PR is included in version 6.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks @Thomaash I will definitly be trying this at work on Monday, but the examples look promising :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout originally made space for invisible nodes (for example after clustering). Now it takes into account only the nodes that are actually rendered solving the problems with sometimes huge empty spaces in hierarchies with clusters.
Also the Hierarchical Layout Methods example was modified to show clustering. It was actually mostly rewritten with new design, various code style improvements and more detailed info added atop of clustering.
PS: Merge #268 into this branch to make the errors go away.