fix(edges-handler): do not access props on null #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data set docs: `Item | null`.
Data set implementation today: `Item | null`.
Data set implementation 5 years ago: `Item | null`.
EdgesHandler.js for the past 5 years:
```javascript
if (item !== undefined) {
item[prop]
}
```
I have no idea why no one noticed this for five years. It either got the
item from the data set or accessed a property on null and crashed.
PS: This has been introduced by a commit saying "updated docs".
yotamberk
approved these changes
Nov 28, 2019
|
🎉 This PR is included in version 6.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data set docs:
Item | null.Data set implementation today:
Item | null.Data set implementation 5 years ago:
Item | null.EdgesHandler.js for the past 5 years:
I have no idea why no one noticed this for five years. It either got the
item from the data set or accessed a property on null and crashed.
PS: This has been introduced by a commit saying "updated docs".