Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting title of custom timebars via function has no arguments #351

Closed
smee opened this issue Mar 6, 2020 · 2 comments · Fixed by #367
Closed

Setting title of custom timebars via function has no arguments #351

smee opened this issue Mar 6, 2020 · 2 comments · Fixed by #367
Labels
bug Something isn't working released

Comments

@smee
Copy link
Contributor

smee commented Mar 6, 2020

The call to the function uses the date as this, not as the function argument. The callback will get an undefined argument but this will be bound to a Date object.

See

vis-timeline/lib/timeline/component/CustomTime.js

Line 164 in d535f69

title = title.call(this.customTime);

should imho be

title = title.call(this,this.customTime);
@yotamberk
Copy link
Member

I believe you are correct! Can you submit a PR for this fix?

@yotamberk yotamberk added the bug Something isn't working label Mar 7, 2020
@smee smee mentioned this issue Mar 11, 2020
Merged
yotamberk added a commit that referenced this issue Mar 11, 2020
@smee @yotamberk
fix(#351): use custom time bar as this in tooltip callbacks (#367)
528cd7e 
* fix(#351): use custom time bar as `this` in tooltip callbacks

* Update CustomTime.js

Co-authored-by: Yotam Berkowitz <yotamberk@gmail.com>
@vis-bot
Copy link
Collaborator

vis-bot commented Mar 11, 2020

🎉 This issue has been resolved in version 7.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#351): use custom time bar as this in tooltip callbacks
3 participants
@smee @yotamberk @vis-bot