Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph2d] Add markers which indicate what happened at the time to graphs #84

Closed
ryamaguchi0220 opened this issue Sep 10, 2019 · 0 comments · Fixed by #86
Closed

[Graph2d] Add markers which indicate what happened at the time to graphs #84

ryamaguchi0220 opened this issue Sep 10, 2019 · 0 comments · Fixed by #86
Labels
enhancement New feature or request graph2d This is only a Graph2D issue help wanted Extra attention is needed

Comments

@ryamaguchi0220
Copy link
Contributor

ryamaguchi0220 commented Sep 10, 2019 •
edited
Loading

Feature Request

description

I think it's nice to be able to add markers which indicate what happened at the time to graphs.
This is useful, e.g, to supplement why the graph has been changed.

Current

We can do almost the same thing by using addCustomTime and setCustomTimeTitle but, It's inconvenient in the use case since the title is displayed only when the time bar is hovered.

スクリーンショット 2019-09-10 14 42 49
@ryamaguchi0220 ryamaguchi0220 changed the title [Graph2d] Add markers which indicate what happened on that time to graphs [Graph2d] Add markers which indicate what happened at the time to graphs Sep 10, 2019
@mojoaxel mojoaxel added enhancement New feature or request help wanted Extra attention is needed graph2d This is only a Graph2D issue labels Sep 10, 2019
@ryamaguchi0220 ryamaguchi0220 mentioned this issue Sep 12, 2019
Merged
mojoaxel pushed a commit that referenced this issue Sep 12, 2019
@ryamaguchi0220 @mojoaxel
feat(timeline): add markers to custom time bars (#86)
808c5a0 
* feat(timeline): add markers to custom time bars (#84)

* chore(docs): update the document (#84)

* fix(docs): move the description to the timeline document (#84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request graph2d This is only a Graph2D issue help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(timeline): add markers to custom time bars
2 participants
@mojoaxel @ryamaguchi0220