Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Graph2d#addCustomTime doesn't work" (#472) #486

Merged
merged 6 commits into from
Jun 23, 2020
Merged

Fix "Graph2d#addCustomTime doesn't work" (#472) #486

merged 6 commits into from
Jun 23, 2020

Conversation

ryamaguchi0220
Copy link
Contributor

@ryamaguchi0220 ryamaguchi0220 commented May 17, 2020 •
edited
Loading

Close #472

The Timeline has the itemSet property but Graph2d doesn't, so the access to itemSet.options causes the error.

demo: https://jsfiddle.net/1u8e4gpc/

@ryamaguchi0220
Copy link
Contributor Author

ryamaguchi0220 commented May 27, 2020 •
edited
Loading

I've realized Graph2d still has one more bug that occurs when dragging any marker, and I'm working on fixing it.
スクリーンショット 2020-05-27 13 10 29

@ryamaguchi0220
Copy link
Contributor Author

ryamaguchi0220 commented May 27, 2020 •
edited
Loading

The cause is Graph2d does not have getScale() and getStep() even though they are referenced in _onDrag , so I added them to Graph2d a268146.

demo: https://jsfiddle.net/tcph3jqf/

FYI, it seems that these bugs were included from #332.

@ryamaguchi0220
Copy link
Contributor Author

@yotamberk Can I have your moment to get review?

ryamaguchi0220
ryamaguchi0220 commented May 27, 2020
View reviewed changes
lib/timeline/Core.js Outdated Show resolved Hide resolved
@ryamaguchi0220 ryamaguchi0220 changed the title fix an access to an undefined object's property (#472) Fix that Graph2d#addCustomTime doesn't work (#472) May 28, 2020
@ryamaguchi0220 ryamaguchi0220 changed the title Fix that Graph2d#addCustomTime doesn't work (#472) Fix "Graph2d#addCustomTime doesn't work" (#472) Jun 2, 2020
@yotamberk yotamberk merged commit ff4a3c1 into visjs:master Jun 23, 2020
@vis-bot
Copy link
Collaborator

vis-bot commented Sep 6, 2020

🎉 This PR is included in version 7.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ryamaguchi0220 ryamaguchi0220 deleted the fix-issue-472 branch April 15, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamberk yotamberk yotamberk approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Graph2d] addCustomTime() is not working
3 participants
@ryamaguchi0220 @vis-bot @yotamberk