Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to disable pulse effect on blocking #12

Closed
dvatp opened this issue Apr 24, 2017 · 2 comments
Closed

Provide option to disable pulse effect on blocking #12

dvatp opened this issue Apr 24, 2017 · 2 comments

Comments

@dvatp
Copy link

dvatp commented Apr 24, 2017

When the blocking prop is enabled and the user clicks outside the dialog a "pulse" effect occurs to provide some feedback that the user cannot dismiss the modal that way.

I recently ran into a case in which I was using a select menu whose options extended below the bottom of the dialog. I am able to select all options without difficulty. However, when I select a menu option that is below the bottom of the modal the click event gets through to SweetModal and it responds by pulsing the modal inappropriately.

I suppose one solution is to modify the select to trap the event so it is never passed on to SweetModal, but it would be nice if there was an option to control this kind of feedback in any case, as not all people like it or need it.

Please add a prop or other means to control the pulse effect while the blocking prop is present. I believe it should be disabled by default.

@bluefirex
Copy link
Member

Added in 0692061, released in v1.1.1

@dvatp
Copy link
Author

dvatp commented May 27, 2017

Awesome. Thanks very much for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants