Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_id_path for Strings #72

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KDGundermann
Copy link
Contributor

Fix for #71

@visoft
Copy link
Owner

visoft commented Aug 1, 2017

Could you add a spec for this change? It shouldn't be too hard given such a simple tweak.

@KDGundermann
Copy link
Contributor Author

Sorry, I'm working on Ubuntu and have currently no setup to run the specs on Windows with IIS

@visoft
Copy link
Owner

visoft commented Aug 1, 2017

You don't have to create or run the Cucumber features, you can write an RSpec spec. For those I use "fixtures" of the EDMX metadata and the results of a query (typically). Take a look at some of the specs already out there. In your case you can probably just get away with a copy of the metadata (found at http://yourserver.com/$metadata).

@KDGundermann
Copy link
Contributor Author

KDGundermann commented Aug 3, 2017

I have installed a Windows system with Ruby (Thanks to rubyinstaller.org !)
I will prepare some specs next week and update the pull request

@visoft
Copy link
Owner

visoft commented Aug 7, 2017

This has been merged into the develop branch. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants