Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SP and DP code using Macros #256

Closed
pranjalchanda08 opened this issue Dec 7, 2023 · 1 comment · Fixed by #268
Closed

Clean up SP and DP code using Macros #256

pranjalchanda08 opened this issue Dec 7, 2023 · 1 comment · Fixed by #268
Assignees
@akashkollipara
Labels
cyancore framework Cyancore framework feature request enhancement Upgrading feature or request terravisor Terravisor related issue
Projects
Terravisor

Comments

@pranjalchanda08
Copy link
Contributor

Describe the bug
This is not a Bug but a good to have change where we use proper defined MACRO functions to declare a SP/DP instance. This would make the file more readable and user friendly.
@pranjalchanda08 pranjalchanda08 added enhancement Upgrading feature or request terravisor Terravisor related issue cyancore framework Cyancore framework feature request labels Dec 7, 2023
@pranjalchanda08 pranjalchanda08 added this to the Boron milestone Dec 7, 2023
@pranjalchanda08 pranjalchanda08 added this to Issues in Terravisor via automation Dec 7, 2023
akashkollipara added a commit that referenced this issue Jan 4, 2024
@akashkollipara
<libresource> Add new macros to create SP and DP
8fa7b8c 
Issue: #256
@akashkollipara akashkollipara linked a pull request Jan 4, 2024 that will close this issue
<libresource> Add new macros to create SP and DP #268
Merged
@akashkollipara
Copy link
Member

Closing this for now.
++ @pranjalchanda08 (FYI)

Terravisor automation moved this from Issues to Done Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akashkollipara akashkollipara

Labels
cyancore framework Cyancore framework feature request enhancement Upgrading feature or request terravisor Terravisor related issue
Projects
Terravisor
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

<libresource> Add new macros to create SP and DP VisorFolks/cyancore
2 participants
@akashkollipara @pranjalchanda08