Bugfix: Use color.lower() for _color_dict keys #2459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_string_to_rgb
helper function usescolor.lower()
to raise a ValueError, because the names are all lower case in_color_dict
. However, in the next line, it still usescolor
as the key to the dict, which means that if the string is upper case, the first logic passes, but then a KeyError happens. This was first reported here in napari:napari/napari#5599 (comment)
So this PR simply makes sure to use
color.lower()
as the key to the_color_dict
dictionary.All tests pass for me locally with this and the napari issue is fixed.