Instanced mesh example #2460
Instanced mesh example #2460
Conversation
| attribute vec3 transform_x; | ||
| attribute vec3 transform_y; | ||
| attribute vec3 transform_z; |
There was a problem hiding this comment.
are these vectors the column vectors of the matrix or the row vectors? would add a comment to the shader making this clear
There was a problem hiding this comment.
i.e. are the values those that are required to compute x'/y'/z' (rows of matrix) or are they the new basis vectors (columns of matrix)?
There was a problem hiding this comment.
Columns vectors (new basis vectors). The mat constructor takes inputs column by column.
Will add comment!
|
❤️ ❤️ ❤️ |
brisvag
force-pushed
the
examples/instanced_mesh
branch
from
4477076
to
4bc83e6
Compare
|
@djhoese this would be nice to get in, but I don't know how to intepret that test failure. Something about discontinuous data being copied? How can I solve it? |
|
Hm and you don't see this warning when you run it locally? Same version of python and numpy? Any idea if the warning is in vispy? |
examples/scene/instanced_mesh.py
Outdated
| self.transforms_x = gloo.VertexBuffer(transforms[..., 0], divisor=1) | ||
| self.transforms_y = gloo.VertexBuffer(transforms[..., 1], divisor=1) | ||
| self.transforms_z = gloo.VertexBuffer(transforms[..., 2], divisor=1) |
There was a problem hiding this comment.
My guess is this is the problem regarding the dis-contiguous data. By doing the indexing there you're now causing striding by 3 (for the 3 elements X/Y/Z) and the VertexBuffer underneath is complaining that the data isn't contiguous and has to be copied.
Lines 438 to 442 in ded8eb9
There was a problem hiding this comment.
So I think if you did a .copy() here when you do the [..., 0] style indexing then you'd at least avoid the warning. If you could find a way to structure the array as (3, M, N) then do indexing [0] then you'd also avoid the copy.
There was a problem hiding this comment.
True, it also happens locally. I think copy is fine, as this si just an example :)
|
Ok, passing now. Anything else before I do one last skim of the code and merge? |
|
Nope, I think it's good to go :) |
|
I downloaded the generated |
A surprisingly simple visual for arbitrarily oriented and colored meshes using instanced rendering.
I started on this as a way to have "true 3D" markers for solving #2453, but adding arbitrary orientations turned out to be relatively easy, and that's useful fo r stuff I'm working on :P
Basically, replace the mesh with a simple icosphere and you get your real pysically sized markers that work in both 2D and 3D. Notice how I applied a scaling transform to the visual in the examples, and the dinosaurs are being stretched correctly.
instanced_mesh.mp4
One thing that's missing (and likely hard to do) compared to the markers is the edge. As far as I know, the only 2 reasonable ways to do it are geometry shaders and multipass rendering?