Fix a few typos in the docs #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
approved these changes
Feb 14, 2024
doc/getting_started/modern-gl.rst
Outdated
|
|
||
|
|
||
| Learning Modern 3D Graphics Programming | ||
| --------------------------------------- | ||
|
|
||
| This `book <https://paroj.github.io/gltut/>`_ is intended to teach you how | ||
| `This book <https://paroj.github.io/gltut/>`_ is intended to teach you how |
There was a problem hiding this comment.
Is there a reason for this change?
There was a problem hiding this comment.
Seems a bit ugly to me to split the noun phrase. In this sense, 'book' could just be any book, the link could be even point to Wikipedia, the reader doesn't know.
The actual faux pas here is to conceal the name of the book.
There was a problem hiding this comment.
Good point! Do you want to put the real name of the online book there instead?
djhoese
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.