Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment, default branches #118

Closed
4 tasks
khawkins98 opened this issue Dec 20, 2018 · 9 comments
Closed
4 tasks

Refactor deployment, default branches #118

khawkins98 opened this issue Dec 20, 2018 · 9 comments
Assignees

Comments

@khawkins98
Copy link
Contributor

khawkins98 commented Dec 20, 2018

Now that we're planning regular release we should:

  • Switch the default branch back to master
  • Deploy all commits on develop to dev.assets.emblstatic.net/vf/
  • Deploy all commits on master to assets.emblstatic.net/vf/
  • Deploy all tags on master to assets.emblstatic.net/vf/{tag}
    • e.g. assets.emblstatic.net/vf/v2.0.0-alpha.1

This was already partly discussed in #28

@khawkins98
Copy link
Contributor Author

I need to rope Peter into this one, so we won't get here until alpha.3

@sturobson
Copy link

We could have an NPM package of the versioned compiled CSS … and use unpkg for the urls that people use?

@khawkins98
Copy link
Contributor Author

I've pinged Peter on this earlier in the week, him and Sandeep should hopefully be tackling soonish.

@peter-walter
Copy link

peter-walter commented Mar 14, 2019

Do we want the tags so granular in the deploy path?
assets.emblstatic.net/vf/v2.0.0-alpha.1
or
assets.emblstatic.net/vf/v2.0

@khawkins98
Copy link
Contributor Author

I think we need some way for, say, WP to opt in to changes. So it might be running on alpha.1 but not be ready yet for alpha.2

@peter-walter peter-walter self-assigned this Mar 14, 2019
@peter-walter
Copy link

@khawkins98
Copy link
Contributor Author

Looks like this is now working with @pwalter-ebi 's most recent edit (#309).

Tagged releases will be added as they're made (so no alpha.1/2/3).

Leaving open as a documentation task.

khawkins98 added a commit that referenced this issue Mar 19, 2019
Reflects the new deployment approach for static assets #118

This is also one of those things where "vanilla vf != EMBL"
@khawkins98
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants