You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the vf-tabs component does not work as expected when used with Angular.
Steps to reproduce
Include the first example of vf-tabs in an Angular application in a route different than the homepage (e.g. /datahubs):
npm start
Select the tab links
Refresh the page - redirection to the homepage
Expected behaviour
The selection of tab links should work within the routes in Angular.
Current behaviour
The selection of tab links removes the path and replaces it with the hash. For example given https://example.com/datahubs the result of clicking on a tab link with href as #test will be https://example.com#test instead of https://example.com/datahubs#test.
Similar to #1937 and in absence of the video at link above, this issue could not be reproduced with given conditions. #2037 has been created to further create Angular version of VF Tabs where this issue will be revisited.
Overview
Currently the
vf-tabs
component does not work as expected when used with Angular.Steps to reproduce
vf-tabs
in an Angular application in a route different than the homepage (e.g./datahubs
):npm start
Expected behaviour
The selection of tab links should work within the routes in Angular.
Current behaviour
The selection of tab links removes the path and replaces it with the hash. For example given
https://example.com/datahubs
the result of clicking on a tab link withhref
as#test
will behttps://example.com#test
instead ofhttps://example.com/datahubs#test
.Screenshots/video
https://watch.screencastify.com/v/xfYDVGkWmeUtsy3s44lO
Possible solution
The issue arises because of the following snippet in
vf-tabs.js
(lines 99 to 101):When using it in Angular it will override its routing behaviour.
A proposed solution is to add an option to pass to the
vfTabs
which controls whether toreplaceState
or not.The text was updated successfully, but these errors were encountered: