Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The links for the VF-tab angular version are not working as expected. #1937

Closed
francisco-ebi opened this issue Apr 14, 2023 · 2 comments
Closed
Assignees

Comments

@francisco-ebi
Copy link
Collaborator

Hello,
I have discovered a bug with the vf-tabs component.
In the Pathogen portal we have this page:
Screenshot 2023-04-14 at 14 54 19

And if the 'ENA result' link is clicked, it doesn't preserve the 'monkeypox' path, as you can see:
Screenshot 2023-04-14 at 14 56 31
In the VF stable site that doesn't happen so I'm assuming there is a clash between how the component updates the url and how Angular handles the routing.
Regards

@nikiforosk
Copy link
Contributor

@bhushan-ebi This looks related to #1845

@bhushan-ebi bhushan-ebi modified the milestone: Bugs and issues Feb 16, 2024
@geetikamalhotra geetikamalhotra changed the title vf-tabs on link click resets url path in Angular project The links for the VF-tab angular version are not working as expected. Mar 21, 2024
@bhushan-ebi
Copy link
Collaborator

With further follow up on this ticket and after discussion with @francisco-ebi , it's observed that this issue doesn't seem to present on the site anymore. #2037 has been created to further create Angular version of VF Tabs where this issue will be revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants