Support multiple tabs #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows for nested tabs, cleans up some JS a bit too
6 tasks
|
Neat feature - although I'd've thought it's not the best UX to nest tabs into tabs? At least there's the option now :) |
sturobson
approved these changes
Jan 7, 2019
|
Accidental support 😁 -- by supporting more than one tab on the page, it also supports nested tabs. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows for nested tabs, cleans up some JS a bit too.
Previously if you had more than one set of tabs on a page, it just fell apart.
I think some of this starts to raise a question about how much JS we should be writing... is there some sort of lightweight framework that can do things like tabs for us .. making a new issue for that.