Docs/onboarding #126
Merged
Docs/onboarding #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feels like a much better ux
sturobson
approved these changes
Jan 7, 2019
| @@ -0,0 +1,56 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
I'll look at some SVGO gulp plugin to avoid:
a) the need to optimise this by hand
b) further PRs with all that Adobe cruft in the SVG
| const SassOutput = './public/css'; | ||
| const autoprefixerOptions = { browsers: ['last 2 versions', '> 5%', 'Firefox ESR'] }; | ||
| const config = JSON.parse(fs.readFileSync('./package.json')); | ||
| global.vfName = config.vfConfig.vfName; |
There was a problem hiding this comment.
can you talk me through this bit later?
There was a problem hiding this comment.
Yep. It's more about the child theme support and thinking that maintenance would be easier when we can get VF-Core and the child theme to use as close to identical config files as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of documentation tweaks to aid in the onboarding.
It also links off to the "pre-alpha" child theme, we can find/replace those as the concept evolves and we have a final name/correct URL.