the one that updates to badges to make them consistent with buttons #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ecstatic-noether-150ab4 ready! 🔨 Explore the source changes: 2e1e6b2 🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-noether-150ab4/deploys/60af8867a11e5a0007f6c956 😎 Browse the preview: https://deploy-preview-1546--ecstatic-noether-150ab4.netlify.app |
|
I think it might be worth doing a major breaking change on buttons to match this too now? @khawkins98 thoughts? |
khawkins98
reviewed
May 27, 2021
khawkins98
approved these changes
May 27, 2021
khawkins98
added a commit
that referenced
this pull request
Jun 8, 2021
* Remove `vf-badge--phases` after upstream removal in vf-badge@2.0.0 * #1546 * Improve placement of `.vf-intro__heading--has-tag .vf-badge` to facilitate assorted widths and multiline headings
khawkins98
added a commit
that referenced
this pull request
Jun 8, 2021
* enhancement: vf-intro badge * Remove `vf-badge--phases` after upstream removal in vf-badge@2.0.0 * #1546 * Improve placement of `.vf-intro__heading--has-tag .vf-badge` to facilitate assorted widths and multiline headings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.